10000 Fix #6449: Fixed Find Planet and Planet View Panel Interaction by IllianiBird · Pull Request #6591 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #6449: Fixed Find Planet and Planet View Panel Interaction #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Fix #6449: Fixed Find Planet and Planet View Panel Interaction #6591

merged 1 commit into from
Apr 11, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Added a missing method call preventing the planet view panel from updating when a system was selected via the 'Find Planet' box.

Fix #6449

@IllianiBird
Fixed Find Planet and Planet View Panel Interaction
8000
ff1e3ad 
- Added a missing method call preventing the planet view panel from updating when a system was selected via the 'Find Planet' box.
@IllianiBird IllianiBird added Bug GUI Severity: Low Issues described as low severity as per the new issue form labels Apr 8, 2025
@IllianiBird IllianiBird self-assigned this Apr 8, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 11.43%. Comparing base (f44952c) to head (ff1e3ad).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/MapTab.java 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6591   +/-   ##
=========================================
  Coverage     11.43%   11.43%           
- Complexity     6451     6454    +3     
=========================================
  Files          1087     1087           
  Lines        139447   139448    +1     
  Branches      21560    21560           
=========================================
+ Hits          15944    15950    +6     
+ Misses       121908   121901    -7     
- Partials       1595     1597    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit 98dd78d into MegaMek:master Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhancock rjhancock rjhancock approved these changes 5BCB

Assignees

@IllianiBird IllianiBird

Labels
Bug GUI Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Find Planet finds the wrong planet
2 participants
@IllianiBird @rjhancock
0