8000 Fix #6439: Fixed Turnover Unit Assignment for Characters Breaking Contract by IllianiBird · Pull Request #6592 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #6439: Fixed Turnover Unit Assignment for Characters Breaking Contract #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Fix #6439: Fixed Turnover Unit Assignment for Characters Breaking Contract #6592

merged 1 commit into from
Apr 11, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Characters breaking contract no longer forfeit ownership of their original units, if the original unit is still present in the campaign.

Fix #6439

@IllianiBird
Fixed Turnover Unit Assignment for Characters Breaking Contract
d1e0634 
- Characters breaking contract no longer forfeit ownership of their original units, if the original unit is still present in the campaign.
@IllianiBird IllianiBird added Bug Personnel Personnel-related Issues GUI Severity: Medium Issues described as medium severity as per the new issue form labels Apr 8, 2025
@IllianiBird IllianiBird self-assigned this Apr 8, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 11.43%. Comparing base (f44952c) to head (d1e0634).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
...rc/mekhq/gui/dialog/RetirementDefectionDialog.java 0.00% 50 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6592   +/-   ##
=========================================
  Coverage     11.43%   11.43%           
- Complexity     6451     6453    +2     
=========================================
  Files          1087     1087           
  Lines        139447   139444    -3     
  Branches      21560    21560           
=========================================
+ Hits          15944    15949    +5     
+ Misses       121908   121903    -5     
+ Partials       1595     1592    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit a9865ed into MegaMek:master Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhancock rjhancock 60F0 rjhancock approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug GUI Personnel Personnel-related Issues Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead Mekwarrior Employee Turnover Buttons Greyed Out
2 participants
@IllianiBird @rjhancock
0