Fixed Error On Loading Campaign That Predates Combat Teams #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed reflection-based `Class.forName` usage in `generateInstanceFromXML` for `CombatTeam` creation. - Replaced with direct instantiation of `CombatTeam` to remove runtime errors.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6628 +/- ##
=========================================
Coverage 11.43% 11.43%
- Complexity 6451 6453 +2
=========================================
Files 1086 1086
Lines 139459 139457 -2
Branches 21571 21571
=========================================
+ Hits 15948 15949 +1
+ Misses 121914 121911 -3
Partials 1597 1597 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class.forNameusage ingenerateInstanceFromXMLforCombatTeamcreation.CombatTeamto remove runtime errors.Dev Notes
This just fixes the loading of combat teams in campaigns that predate Combat Teams as a thing. The failure didn't actually cause any problems, but it did throw up all over the log so with us hoping 50.05 will make Milestone I figured it was worth tidying up.