Fix #6618: Implemented Pre-Tukayyid Clan Tech Restrictions to Force Generation #6621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new constant `BATTLE_OF_TUKAYYID`. - Updated unit generation logic to restrict Clan technology in non-Clan forces before Tukayyid.
…d on campaign timeline. - Replaced duplicate "isFactionClan" and "isBeforeBattleOfTukayyid" methods with streamlined versions. - Added detailed documentation and JavaDoc comments for the new helper methods `filterOutClanTech` and `isFactionClan`. - Removed redundant comments and legacy code snippets for improved readability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6621 +/- ##
=========================================
Coverage 11.43% 11.43%
- Complexity 6451 6456 +5
=========================================
Files 1086 1086
Lines 139459 139482 +23
Branches 21571 21577 +6
=========================================
+ Hits 15948 15953 +5
- Misses 121914 121932 +18
Partials 1597 1597 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BATTLE_OF_TUKAYYID.Fix #6618
Dev Notes
Me and Hammer determined last year that Tukayyid would be the cut-off point after which the Houses started relaxing their tendency to hoard Clantech. Generally speaking, prior to this date you would occasionally see units in the Clan Invasion theatre rocking the odd bit of Clantech, however these unique situations are not something we can easily model so it's better to just bar non-Clan factions from accessing Clantech prior to the watershed.