8000 Fix #6653: Updated Doctor/Tech Uses Administration to No Longer Factor Administration into Experience Level by IllianiBird · Pull Request #6655 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #6653: Updated Doctor/Tech Uses Administration to No Longer Factor Administration into Experience Level #6655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IllianiBird
Copy link
Collaborator
@IllianiBird IllianiBird commented Apr 13, 2025
  • Removed the use of alternative quality averaging and administration skill checks for experience level calculation across multiple roles.

Fix #6653

- Added warnings to tooltips for "Techs Use Administration" and "Doctors Use Administration" options.
- Clarified the behavior when these options are enabled mid-campaign, specifically highlighting the impact on experience levels.
@IllianiBird IllianiBird added GUI UX User experience Campaign Options Relates to, or includes, campaign option changes labels Apr 13, 2025
@IllianiBird IllianiBird self-assigned this Apr 13, 2025
Copy link
codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 11.42%. Comparing base (f944c41) to head (0fdba41).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/personnel/Person.java 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6655      +/-   ##
============================================
+ Coverage     11.41%   11.42%   +0.01%     
- Complexity     6475     6483       +8     
============================================
  Files          1094     1094              
  Lines        140752   140699      -53     
  Branches      21837    21814      -23     
============================================
+ Hits          16064    16078      +14     
+ Misses       123031   122966      -65     
+ Partials       1657     1655       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Removed the use of alternative quality averaging and administration skill checks for experience level calculation across multiple roles.
@IllianiBird IllianiBird changed the title Fix #6651: Updated Tooltip Warnings for Administration Options Fix #6653: Updated Tooltip Warnings for Administration Options Apr 13, 2025
@IllianiBird IllianiBird changed the title Fix #6653: Updated Tooltip Warnings for Administration Options Fix #6653: Updated Doctor/Tech Uses Administration to No Longer Factor Administration into Experience Level Apr 13, 2025
@IllianiBird IllianiBird merged commit c99c3ac into MegaMek:master Apr 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign Options Relates to, or includes, campaign option changes GUI UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue][0.50.05-SNAPSHOT]Doctor and Tech Skills do not contribute to Skill Level
1 participant
0