Fix #6668: Fixed Creative Accounting for Ammunition in Resupplies #6671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stopped the employer depot crew from counting every ton of ammunition as five tons. Where did the other 4 tons go? Well, where else do you think the Smugglers get their wares?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6671 +/- ##
============================================
- Coverage 11.41% 11.41% -0.01%
Complexity 6479 6479
============================================
Files 1094 1094
Lines 140770 140770
Branches 21839 21838 -1
============================================
- Hits 16070 16067 -3
- Misses 123042 123046 +4
+ Partials 1658 1657 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6668
Dev Notes
The Resupply module went through a lot of revisions during development, as we sought to 'get it right'. During an early build ammunition was delivered in batches of five tons. So every time you go LRMs, for example, you would get five tons of LRMs.
However, we received feedback that this didn't feel great, so instead we moved ammunition to be delivered in patches of 1 ton.
Unfortunately, I missed a single instance where the old 5 tons was being used. Meaning ammunition was being treated as if it weighed 5x as much as was actually delivered.