8000 Fix 2 unreported problems in procurement table by goron111 · Pull Request #6690 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 2 unreported problems in procurement table #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix 2 unreported problems in procurement table #6690

merged 2 commits into from
Apr 16, 2025

Conversation

goron111
Copy link
Contributor

While working on #6674 i found and fixed 2 unreported problems.

  • Fixed sorting for the "Total Cost" column in the procurement table
  • Fixed cell update for "Total Cost" column if quantity is incremented / decremented

@codecov Codecov
Copy link
codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 11.41%. Comparing base (91adec9) to head (4141489).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...kHQ/src/mekhq/gui/model/ProcurementTableModel.java 0.00% 5 Missing ⚠️
MekHQ/src/mekhq/gui/CommandCenterTab.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6690      +/-   ##
============================================
- Coverage     11.41%   11.41%   -0.01%     
+ Complexity     6480     6478       -2     
============================================
  Files          1095     1095              
  Lines        140754   140759       +5     
  Branches      21807    21808       +1     
============================================
- Hits          16069    16066       -3     
- Misses       123029   123034       +5     
- Partials       1656     1659       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@goron111 goron111 mentioned this pull request Apr 15, 2025
Merged
6 tasks
@IllianiBird
Copy link
Collaborator

So something I've noticed is that the table is only updating when it's interacted with, not when the items are added. This can be seen by going into the purchase unit or part dialog, adding a bunch of the same unit and observing the table. Unless the table is interacted with - or the tab is changed - the total will not update.

Is that something you could look into?

8000

IllianiBird
IllianiBird approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator
@IllianiBird IllianiBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we should take a look at why the table isn't updating when incrementing items via the purchase dialogs.

@IllianiBird IllianiBird merged commit 03c4fc2 into MegaMek:master Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IllianiBird IllianiBird IllianiBird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goron111 @IllianiBird
0