8000 Fixed Prisoner Capacity of Injured Prisoners by IllianiBird · Pull Request #6734 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Prisoner Capacity of Injured Prisoners #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Fixed Prisoner Capacity of Injured Prisoners #6734

merged 1 commit into from
Apr 23, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Reversed the conditional to properly detect prisoners without a doctor (== null).

@IllianiBird
Fixed Prisoner Capacity of Injured Prisoners
2ca5e76 
- Reversed the conditional to properly detect prisoners *without* a doctor (`== null`).
@IllianiBird IllianiBird added Bug Severity: Medium Issues described as medium severity as per the new issue form labels Apr 22, 2025
@IllianiBird IllianiBird self-assigned this Apr 22, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.42%. Comparing base (202e114) to head (2ca5e76).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...n/randomEvents/prisoners/PrisonerEventManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6734   +/-   ##
=========================================
  Coverage     11.41%   11.42%           
- Complexity     6479     6482    +3     
=========================================
  Files          1095     1095           
  Lines        140802   140802           
  Branches      21811    21811           
=========================================
+ Hits          16079    16080    +1     
+ Misses       123067   123066    -1     
  Partials       1656     1656

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS requested a review from Copilot April 23, 2025 02:17
Copilot
Copilot AI reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the prisoner capacity calculation by updating the conditional to properly detect injured prisoners without an assigned doctor.

  • Reversed the conditional check for prisoner doctor assignment.
  • Ensured that only injured prisoners lacking a doctor increase capacity usage.

@HammerGS HammerGS merged commit c6b7e02 into MegaMek:master Apr 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@IllianiBird IllianiBird

Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @HammerGS
0