Remove Redundant Logging in SkillType Updates #6738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Stopped skill type compatibility handler spamming the log whenever a save is loaded.
- Stopped skill type compatibility handler spamming the log whenever a save is loaded.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6738 +/- ##
=========================================
Coverage 11.41% 11.42%
- Complexity 6479 6481 +2
=========================================
Files 1095 1095
Lines 140802 140793 -9
Branches 21811 21811
=========================================
+ Hits 16079 16080 +1
+ Misses 123067 123055 -12
- Partials 1656 1658 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant logging within the compatibilityHandler method of SkillType to prevent log spamming when a save is loaded.
- Removed logger.info calls for sub type, first attribute, and second attribute updates.
- Streamlined the compatibilityHandler method to update properties without excessive log output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.