Fix #4801: Fixed Infantry Capacity Calculation in Transport Report #6747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved incorrect calculation of infantry capacity in `Unit.java`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6747 +/- ##
=========================================
Coverage 11.40% 11.40%
- Complexity 6477 6478 +1
=========================================
Files 1095 1095
Lines 140888 140888
Branches 21841 21841
=========================================
+ Hits 16069 16070 +1
Misses 123160 123160
+ Partials 1659 1658 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the infantry capacity calculation in the transport report by updating the logic to divide each bay's capacity by the platoon weight.
- Fixed calculation logic in getInfantryCapacity
- Reordered the import for CrewType
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/campaign/unit/Unit.java:2071
- Ensure that getPlatoonType().getWeight() is never zero to avoid potential division by zero errors. Consider adding a check or safeguard if this possibility exists.
bays += bay.getCapacity() / ((InfantryBay) bay).getPlatoonType().getWeight();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit.java.Fix #4801