8000 Fixed Exception When Adopting Child with Existing Parents (Sentry) by IllianiBird · Pull Request #6756 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Exception When Adopting Child with Existing Parents (Sentry) #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IllianiBird
Copy link
Collaborator
@IllianiBird IllianiBird commented Apr 24, 2025
  • Resolved an issue where adopting a child with existing parents triggered a ConcurrentModificationException by creating a new list and iterating through that instead of the raw genealogy object.

Fix Sentry Report

- Resolved an issue where adopting a child with existing parents triggered an exception by correctly handling the removal of original parents.
@IllianiBird IllianiBird added Bug Personnel Personnel-related Issues Severity: Medium Issues described as medium severity as per the new issue form labels Apr 24, 2025
@IllianiBird IllianiBird self-assigned this Apr 24, 2025
…ion workflow to prevent null pointer exceptions.

- Refactored code to consolidate genealogy interactions and improve readability.
Copy link
codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 11.40%. Comparing base (1702c4a) to head (93abbd1).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6756   +/-   ##
=========================================
  Coverage     11.40%   11.40%           
- Complexity     6477     6480    +3     
=========================================
  Files          1095     1095           
  Lines        140888   140956   +68     
  Branches      21841    21858   +17     
=========================================
+ Hits          16069    16081   +12     
- Misses       123160   123216   +56     
  Partials       1659     1659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit b21a879 into MegaMek:master Apr 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0