10000 Fix #6758: Fixed Ransom Events Not Ransoming Prisoners by IllianiBird · Pull Request #6759 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #6758: Fixed Ransom Events Not Ransoming Prisoners #6759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Fix #6758: Fixed Ransom Events Not Ransoming Prisoners #6759

merged 1 commit into from
Apr 24, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Adjusted dialog to modal to ensure the dialog is resolved before we check for user response.

Fix #6758

@IllianiBird
Fix MegaMek#6758: Fixed Ransom Events Not Ransoming Prisoners
d66a80c 
- Adjusted dialog to modal to ensure the dialog is resolved before we check for user response.
@IllianiBird IllianiBird added Bug Severity: High Issues described as high severity as per the new issue form labels Apr 24, 2025
@IllianiBird IllianiBird self-assigned this Apr 24, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.40%. Comparing base (1702c4a) to head (d66a80c).
Report is 34 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6759   +/-   ##
=========================================
  Coverage     11.40%   11.40%           
- Complexity     6477     6480    +3     
=========================================
  Files          1095     1095           
  Lines        140888   140938   +50     
  Branches      21841    21854   +13     
=========================================
+ Hits          16069    16080   +11     
- Misses       123160   123201   +41     
+ Partials       1659     1657    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit 41fe7a4 into MegaMek:master Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IllianiBird IllianiBird

Labels
Bug Severity: High Issues described as high severity as per the new issue form
Projects
None yet
Milestone
No milestone 4310
Development

Successfully merging this pull request may close these issues.

[Issue] Accepting a prisoner ransom doesn't actually do anything
1 participant
@IllianiBird
0