Fix #5441: Added Student Counts to Personnel Report #6751
Conversation
- Added logic to track and count students in `PersonnelReport`. - Updated both combat and support personnel reporting to include the number of student personnel.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6751 +/- ##
============================================
- Coverage 11.40% 11.40% -0.01%
+ Complexity 6477 6475 -2
============================================
Files 1095 1095
Lines 140888 140896 +8
Branches 21841 21843 +2
============================================
- Hits 16069 16065 -4
- Misses 123160 123171 +11
- Partials 1659 1660 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Fix #5441 by adding logic to count student personnel in both combat and support personnel reports.
- Added a new counter and condition 8000 al for student personnel in the combat report.
- Added a new counter and conditional for student personnel in the support report.
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/campaign/report/PersonnelReport.java:110
- Consider adding unit tests to verify that the new student counting logic works correctly for both combat and support personnel scenarios.
.append(String.format("%-30s %4s\n", "Student Combat Personnel", countStudents))
| } else if (primarySupport && p.getStatus().isStudent()) { | ||
| countStudents++; |
There was a problem hiding this comment.
Review whether counting student support personnel should depend on the 'primarySupport' flag. If all student support personnel are intended to be counted regardless of primary support status, consider removing the primarySupport condition.
| } else if (primarySupport && p.getStatus().isStudent()) { | |
| countStudents++; | |
| } else if (p.getStatus().isStudent()) { |
Copilot uses AI. Check for mistakes.
PersonnelReport.Fix #5441
Dev Notes
I didn't add children as the personnel report isn't meant for dependents and other 'hangers on'. It's specifically set up for combat and support personnel.