8000 Fix #6750: Corrected Destination Edges by IllianiBird · Pull Request #6752 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #6750: Corrected Destination Edges #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

IllianiBird
Copy link
Collaborator
  • Corrected destination edge to use static for 'opposite' and not 'north' board edge.

Fix #6750

- Corrected destination edge to use static for 'opposite' and not 'north' board edge.
@IllianiBird IllianiBird added Bug Data Hammertime Severity: High Issues described as high severity as per the new issue form labels Apr 23, 2025
@IllianiBird IllianiBird self-assigned this Apr 23, 2025
Copy link
codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.40%. Comparing base (1702c4a) to head (d90b919).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6752      +/-   ##
============================================
- Coverage     11.40%   11.40%   -0.01%     
+ Complexity     6477     6476       -1     
============================================
  Files          1095     1095              
  Lines        140888   140888              
  Branches      21841    21841              
============================================
- Hits          16069    16065       -4     
- Misses       123160   123164       +4     
  Partials       1659     1659              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS requested a review from Copilot April 24, 2025 01:15
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (20)
  • MekHQ/data/scenariotemplates/Breakthrough.xml: Language not supported
  • MekHQ/data/scenariotemplates/Convoy Escort.xml: Language not supported
  • MekHQ/data/scenariotemplates/Convoy Interdiction.xml: Language not supported
  • MekHQ/data/scenariotemplates/Convoy Raid.xml: Language not supported
  • MekHQ/data/scenariotemplates/Critical Convoy Escort.xml: Language not supported
  • MekHQ/data/scenariotemplates/Diversion Engagement.xml: Language not supported
  • MekHQ/data/scenariotemplates/Emergency Convoy Defense - Player - Low-Atmosphere.xml: Language not supported
  • MekHQ/data/scenariotemplates/Emergency Convoy Defense - Player - VTOL.xml: Language not supported
  • MekHQ/data/scenariotemplates/Emergency Convoy Defense - Player.xml: Language not supported
  • MekHQ/data/scenariotemplates/Emergency Convoy Defense.xml: Language not supported
  • MekHQ/data/scenariotemplates/Frontline Breakthrough.xml: Language not supported
  • MekHQ/data/scenariotemplates/Frontline Disruption.xml: Language not supported
  • MekHQ/data/scenariotemplates/Intercept Engagement.xml: Language not supported
  • MekHQ/data/scenariotemplates/Interception Defense.xml: Language not supported
  • MekHQ/data/scenariotemplates/Low-Atmosphere DropShip Assault.xml: Language not supported
  • MekHQ/data/scenariotemplates/Low-Atmosphere DropShip Escort.xml: Language not supported
  • MekHQ/data/scenariotemplates/Picket Line Breakthrough.xml: Language not supported
  • MekHQ/data/scenariotemplates/Space Blockade Run.xml: Language not supported
  • MekHQ/data/scenariotemplates/Space DropShip Intercept.xml: Language not supported
  • MekHQ/data/scenariotemplates/Tactical Withdrawal.xml: Language not supported

@HammerGS HammerGS merged commit 25dd910 into MegaMek:master Apr 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Data Hammertime Severity: High Issues described as high severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [0.50.05-nightly-2025-04-23] Convoys have the wrong destination set.
2 participants
0