Fix #6778: Prisoners Are Now Correctly Released When Enemy Routs #6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Dev Notes When the enemy routs all held prisoners are meant to be ransomed or released. However, we were only triggering those events if there were _no_ prisoners, not when there _were_ prisoners.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6779 +/- ##
=========================================
Coverage 11.45% 11.45%
- Complexity 6501 6503 +2
=========================================
Files 1098 1098
Lines 140870 140869 -1
Branches 21843 21842 -1
=========================================
+ Hits 16135 16140 +5
+ Misses 123061 123051 -10
- Partials 1674 1678 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #6778 by correcting the logic used to trigger prisoner release events when the enemy routs.
- The conditional checks for friendly and current prisoners have been reversed to ensure events trigger when prisoner collections are non-empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6778
Dev Notes
When the enemy routs all held prisoners are meant to be ransomed or released. However, we were only triggering those events if there were no prisoners, not when there were prisoners.