Fix #6785: Fixed NPE on New Contract when Negotiator Lacks Negotiation Skill #6786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Dev Notes As per rules as written contract negotiation uses the Negotiation skill of the negotiator. However, we were not verifying that the negotiator _had_ the Negotiation skill before performing the check, resulting in an error.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null pointer exception in the contract negotiation flow by adding explicit null checks for the negotiator's negotiation skill before accessing its experience level.
- Added static import for S_NEG for clarity.
- Replaced chained null checks with explicit conditional statements for adminCommand, adminTransport, and adminLogistics.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mas
8000
ter #6786 +/- ##
=========================================
Coverage 11.45% 11.45%
- Complexity 6501 6506 +5
=========================================
Files 1098 1098
Lines 140870 140875 +5
Branches 21843 21845 +2
=========================================
+ Hits 16135 16144 +9
+ Misses 123061 123057 -4
Partials 1674 1674 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6785
Dev Notes
As per rules as written contract negotiation uses the Negotiation skill of the negotiator. However, we were not verifying that the negotiator had the Negotiation skill before performing the check, resulting in an error.