Fix: #6782 Fixed Campaign Summary Displays of Kitchen Capacity and Injured Personnel #6795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel ### Dev Notes The check for whether kitchens were in capacity had managed to get inverted at some point, causing the Campaign Summary pane to display incorrect information. Furthermore, the number of injured personnel was malformed, causing all personnel to display as injured. Both issues have now been fixed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6795 +/- ##
============================================
- Coverage 11.46% 11.44% -0.03%
+ Complexity 6508 6501 -7
============================================
Files 1098 1099 +1
Lines 140812 140896 +84
Branches 21831 21837 +6
============================================
- Hits 16150 16127 -23
- Misses 122995 123104 +109
+ Partials 1667 1665 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this should be in 50.06 because it addresses an issue with fatigue recovery and also is a visual bug we've had a couple of user queries about over on Discord. |
Scoppio
requested changes
May 1, 2025
Scoppio
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6782
Dev Notes
The check for whether kitchens were in capacity had managed to get inverted at some point, causing the Campaign Summary pane to display incorrect information.
Furthermore, the number of injured personnel was malformed, causing all personnel to display as injured.
Both issues have now been fixed.