Fix: Fixed Error when Adopting Child With Existing Parents #6804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MegaMek#6799 When adopting a child we remove their previous (presumably dead) parents. However, this run into an issue previously thought fixed where we were trying to remove parents while also processing those parents at the same time.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6804 +/- ##
============================================
- Coverage 11.45% 11.44% -0.02%
+ Complexity 6506 6500 -6
============================================
Files 1098 1098
Lines 140875 140853 -22
Branches 21845 21839 -6
============================================
- Hits 16144 16124 -20
+ Misses 123057 123053 -4
- Partials 1674 1676 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scoppio
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6799
When adopting a child we remove their previous (presumably dead) parents. However, this run into an issue previously thought fixed where we were trying to remove parents while also processing those parents at the same time.