8000 Revert "Fix #3111: Added Heroic and Legendary Skill Levels" by IllianiBird · Pull Request #6802 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Fix #3111: Added Heroic and Legendary Skill Levels" #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

IllianiBird
Copy link
Collaborator

Reverts #6623

During a team meeting we decided to reduce the scope of 50.06. This PR is too high risk for inclusion.

Comment on lines +213 to +214
int rating = Integer
.parseInt(wn2.getAttributes().getNamedItem("rating").getTextContent());

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
@IllianiBird IllianiBird merged commit 121bc71 into master Apr 28, 2025
4 checks passed
@IllianiBird IllianiBird deleted the revert-6623-missingSkillLevels branch April 28, 2025 19:40
Copy link
tapenvy-sentry bot commented May 1, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 7 megamek.common.Entity in getLocationStatus View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0