8000 Fix: Added Missing Exceptional Attribute Charisma SPA by IllianiBird · Pull Request #6818 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Added Missing Exceptional Attribute Charisma SPA #6818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IllianiBird
Copy link
Collaborator

Fix #6817

Dev Notes

For some reason exceptional attribute charisma was set up in code, but not included in the spa file. Most likely this was a copy-paste error.

### Dev Notes
For some reason exceptional attribute charisma was set up in code, but not included in the spa file. Most likely this was a copy-paste error.
@IllianiBird IllianiBird added Bug SPA Any issue relating to SPA's. Includes Bugs and RFE Severity: Medium Issues described as medium severity as per the new issue form labels Apr 29, 2025
@IllianiBird IllianiBird self-assigned this Apr 29, 2025
Copy link
codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.45%. Comparing base (10985a2) to head (c922c2b).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6818      +/-   ##
============================================
- Coverage     11.45%   11.45%   -0.01%     
+ Complexity     6506     6502       -4     
============================================
  Files          1098     1098              
  Lines        140875   140807      -68     
  Branches      21845    21829      -16     
============================================
- Hits          16144    16135       -9     
+ Misses       123057   123003      -54     
+ Partials       1674     1669       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird changed the title Fix #6817: Added Missing Exceptional Attribute Charisma SPA Fix: Added Missing Exceptional Attribute Charisma SPA Apr 30, 2025
@Scoppio Scoppio merged commit be0765e into MegaMek:master May 1, 2025
4 checks passed
@IllianiBird IllianiBird deleted the missingSPAExceptionalAttributeCharisma branch June 7, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form SPA Any issue relating to SPA's. Includes Bugs and RFE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[50.05] Text display issue - Exceptional Attribute - Charisma displaying incorrectly in 'Edit Person' menu
2 participants
0