Fix: Reset Initial Delay of Tooltips to Pre-50.05 Values #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Dev Notes We had some player feedback that the initial delay in 50.05 was too short. The issue revolves around the conflicting tooltip needs for MekHQ and MegaMek. With whatever settings are assigned in MekHQ propagating into MegaMek. While later changing the settings in MegaMek propagate back onto MekHQ for the rest of the session. Unfortunately, both MekHQ and MegaMek share a tooltip manager instance, so this issue is not easily resolved. MekHQ desperately needs tooltips to not dismiss. However, players have long lived with tooltips taking a while to display, so an intermediate solution is to revert back to <50.05 settings for tooltip display delay, while keeping the changes that stop tooltips from prematurely dismissing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6824 +/- ##
=========================================
Coverage 11.45% 11.45%
- Complexity 6499 6501 +2
=========================================
Files 1098 1098
Lines 140854 140806 -48
Branches 21841 21829 -12
=========================================
+ Hits 16130 16135 +5
+ Misses 123050 123001 -49
+ Partials 1674 1670 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scoppio
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6819
Dev Notes
We had some player feedback that the initial delay in 50.05 was too short. The issue revolves around the conflicting tooltip needs for MekHQ and MegaMek. With whatever settings are assigned in MekHQ propagating into MegaMek. While later changing the settings in MegaMek propagate back onto MekHQ for the rest of the session.
Unfortunately, both MekHQ and MegaMek share a tooltip manager instance, so this issue is not easily resolved. MekHQ desperately needs tooltips to not dismiss. However, players have long lived with tooltips taking a while to display, so an intermediate solution is to revert back to <50.05 settings for tooltip display delay, while keeping the changes that stop tooltips from prematurely dismissing.