Improvement: Added Faction Icons to Briefing Room #6858
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds faction icons to the briefing room by displaying the employer and enemy faction logos.
- Introduces a new UI component (a JPanel) for displaying faction icons in MissionViewPanel.
- Adds a new method (getBelligerentsPanel) in AtBContract to generate a panel with scaled faction logos and a divider.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/view/MissionViewPanel.java | Added a new JPanel field and updated methods to incorporate faction icons in the display. |
| MekHQ/src/mekhq/campaign/mission/AtBContract.java | Implemented getBelligerentsPanel to build and return the faction icons panel. |
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/gui/view/MissionViewPanel.java:71
- [nitpick] The field name 'lblBelligerents' is misleading as it is a JPanel and not a JLabel. Consider renaming it to 'pnlBelligerents' for better clarity.
private JPanel lblBelligerents;
| @@ -169,18 +170,18 @@ private void fillStats() { | |||
|
|
|||
| private void fillStatsBasic() { | |||
| lblStatus = new JLabel(); | |||
| lblBelligerents = new JPanel(); | |||
There was a problem hiding this comment.
[nitpick] The initialization of 'lblBelligerents' here is later overwritten in fillStatsAtBContract(); consider removing this redundant instantiation if it is not used elsewhere.
| lblBelligerents = new JPanel(); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This is just how I set up CO IIC. At some point I'll got back and address this, but this PR is not the time.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6858 +/- ##
============================================
- Coverage 11.57% 11.56% -0.01%
+ Complexity 6609 6607 -2
============================================
Files 1100 1100
Lines 140971 140990 +19
Branches 21845 21839 -6
============================================
- Hits 16311 16308 -3
- Misses 122960 122985 +25
+ Partials 1700 1697 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Requires #6857
The briefing room was looking a bit empty with the challenge skulls removed, so I went ahead and added the employer and enemy faction to the display, instead.
This is a very small change, but one I think has a lot of impact and something I would really like in 50.06