8000 Fix: #6775 AutoLogistics properly considers `AmmoStorage` as ammo and not other by psikomonkie · Pull Request #6859 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #6775 AutoLogistics properly considers AmmoStorage as ammo and not other #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Fix: #6775 AutoLogistics properly considers AmmoStorage as ammo and not other #6859

merged 2 commits into from
May 5, 2025

Conversation

psikomonkie
Copy link
Collaborator

Fixes #6775

Campaign.getDefaultStockPercent(Part) should now handle AmmoStorage parts with CampaignOptions::getAutoLogisticsAmmunition instead of CampaignOptions::getAutoLogisticsOther

@psikomonkie
Issue MegaMek#6775: Campaign.getDefaultStockPercent(Part) should no…
07379ea 
…w handle `AmmoStorage` parts with `CampaignOptions::getAutoLogisticsAmmunition` instead of `CampaignOptions::getAutoLogisticsOther`
@codecov Codecov
Copy link
codecov bot commented May 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.57%. Comparing base (3f2d5f0) to head (f61f941).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6859      +/-   ##
============================================
+ Coverage     11.52%   11.57%   +0.05%     
- Complexity     6567     6610      +43     
============================================
  Files          1100     1100              
  Lines        140971   140971              
  Branches      21845    21845              
============================================
+ Hits          16243    16315      +72     
+ Misses       123030   122960      -70     
+ Partials       1698     1696       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psikomonkie psikomonkie added Bug Parts/Repair/Refit Severity: Low Issues described as low severity as per the new issue form labels May 3, 2025
@psikomonkie psikomonkie requested a review from a team May 3, 2025 19:26
@IllianiBird
Copy link
Collaborator

Currently auto logistics considers 'weapons' to also fall under 'other'. I don't suppose you fancy a follow-up PR to separate out weapons into their own category? We've have a handful of user requests on Discord.

@psikomonkie
Copy link
Collaborator Author

Currently auto logistics considers 'weapons' to also fall under 'other'. I don't suppose you fancy a follow-up PR to separate out weapons into their own category? We've have a handful of user requests on Discord.

I saw that issue report, I was torn between taking it myself or marking it “for new Dev” and offering to help whoever picks it up.

@psikomonkie psikomonkie mentioned this pull request May 4, 2025
Closed
3 tasks
@psikomonkie psikomonkie merged commit d050642 into MegaMek:master May 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IllianiBird IllianiBird IllianiBird approved these changes

Assignees
No one assigned
Labels
Bug Parts/Repair/Refit Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] AC/5 Ammo being considered a 'weapon'/'other' instead of ammo
2 participants
@psikomonkie @IllianiBird
0