Improvement: Added In-Game Tutorial Documentation to the Briefing Room for AtB and StratCon Contracts #6862
Conversation
…m for AtB and StratCon Contracts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6862 +/- ##
=========================================
Coverage 11.56% 11.57%
- Complexity 6607 6610 +3
=========================================
Files 1100 1100
Lines 140990 141068 +78
Branches 21839 21846 +7
=========================================
+ Hits 16308 16328 +20
- Misses 122985 123039 +54
- Partials 1697 1701 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces in-game tutorial documentation for AtB and StratCon contracts by adding a new tutorial panel and refactoring the mission stats layout.
- Adds a new right-panel tutorial display using a JEditorPane with inline CSS styling.
- Moves most stat label additions from pnlStats to a newly created leftPanel for better layout management.
- Introduces minor refactoring by reassigning pnlStats and rearranging layout components.
Files not reviewed (1)
- MekHQ/resources/mekhq/resources/ContractViewPanel.properties: Language not supported
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/gui/view/MissionViewPanel.java:1118
- [nitpick] The mix of 'pnlStats' and 'leftPanel' for displaying mission stats may cause confusion; consider aligning their naming or consolidating them for clarity.
pnlStats = new JPanel(new FlowLayout(FlowLayout.LEFT));
| AtBContract contract = (AtBContract) mission; | ||
| Campaign campaign = gui.getCampaign(); | ||
|
|
||
| // TODO : Switch me to use IUnitRating | ||
| String[] ratingNames = {"F", "D", "C", "B", "A"}; | ||
| pnlTutorialText = new JPanel(); |
There was a problem hiding this comment.
The panel 'pnlTutorialText' is declared but not used in the layout; consider removing it or integrating it into the UI if it is intended to display tutorial information.
| pnlTutorialText = new JPanel(); | |
| pnlTutorialText = new JPanel(); | |
| pnlTutorialText.setBorder(BorderFactory.createTitledBorder("Tutorial Information")); | |
| GridBagConstraints gbcTutorialText = new GridBagConstraints(); | |
| gbcTutorialText.gridx = 0; | |
| gbcTutorialText.gridy = 0; | |
| gbcTutorialText.gridwidth = 2; | |
| gbcTutorialText.insets = new Insets(5, 5, 5, 5); | |
| gbcTutorialText.fill = GridBagConstraints.BOTH; | |
| gbcTutorialText.weightx = 1.0; | |
| gbcTutorialText.weighty = 0.2; | |
| leftPanel.add(pnlTutorialText, gbcTutorialText); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This matches the current layout of the code. It's not great, but changing that would require significant rewrites and is outside the scope of this PR.
|
Recent changes to master have broken this. Working on a fix. |
|
Fixed |
Includes information about Scenarios, CVP, and Combat Roles.
@HammerGS @Scoppio as requested.