8000 Fixed: Corrected Formatting of Bondsref Messaging by IllianiBird · Pull Request #6886 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed: Corrected Formatting of Bondsref Messaging #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

IllianiBird
Copy link
Collaborator

Stops this nonsense:

image

@IllianiBird IllianiBird self-assigned this May 6, 2025
@IllianiBird IllianiBird added Bug GUI Severity: Low Issues described as low severity as per the new issue form labels May 6, 2025
Copy link
codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.57%. Comparing base (3deb7af) to head (e0ee99c).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6886      +/-   ##
============================================
+ Coverage     11.52%   11.57%   +0.04%     
- Complexity     6571     6609      +38     
============================================
  Files          1100     1100              
  Lines        140971   140971              
  Branches      21845    21845              
============================================
+ Hits          16249    16311      +62     
+ Misses       123022   122960      -62     
  Partials       1700     1700              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -1,7 +1,7 @@
# suppress inspection "UnusedMessageFormatParameter" for whole file
# suppress inspection "UnusedProperty" for whole file
# CapturePrisoners.java
bondsref.report={0} has performed {0}<b>Bondsref</b>{1} instead of accepting capture by our forces.\
bondsref.report={0} has performed {1}<b>Bondsref</b>{2} instead of accepting capture by our forces.\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space between {1}Bondsref{2}?
I will consider that you know better than me XD

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are for color tags

@Scoppio Scoppio merged commit b881136 into MegaMek:master May 6, 2025
6 checks passed
@Scoppio
Copy link
Collaborator
Scoppio commented May 7, 2025

Fixes #6884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0