8000 Improvement: Deprecated Climbing by IllianiBird · Pull Request #6887 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvement: Deprecated Climbing #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

IllianiBird
Copy link
Collaborator
@IllianiBird IllianiBird commented May 6, 2025

Climbing is actually AntiMek in MekHQ, no need for two skills that cover the same thing

@IllianiBird IllianiBird self-assigned this May 6, 2025
Copy link
codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 11.57%. Comparing base (621fe04) to head (518f07d).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...ampaign/personnel/skills/SkillDeprecationTool.java 0.00% 5 Missing ⚠️
...gn/personnel/generator/AbstractSkillGenerator.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6887      +/-   ##
============================================
+ Coverage     11.56%   11.57%   +0.01%     
- Complexity     6607     6610       +3     
============================================
  Files          1100     1100              
  Lines        140990   141034      +44     
  Branches      21839    21846       +7     
============================================
+ Hits          16308    16329      +21     
- Misses       122985   123004      +19     
- Partials       1697     1701       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird closed this May 6, 2025
@IllianiBird IllianiBird changed the title Improvement: Deprecated Climbing & Archery Improvement: Deprecated Climbing May 6, 2025
@IllianiBird IllianiBird reopened this May 6, 2025
@Scoppio Scoppio merged commit cb7d0e4 into MegaMek:master May 6, 2025
6 checks passed
@IllianiBird IllianiBird deleted the deprecatedClimbingArchery branch June 7, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0