Improvement: Added Additional Testing for Skills #6896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoppio
approved these changes
May 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6896 +/- ##
============================================
- Coverage 11.57% 11.57% -0.01%
- Complexity 6610 6618 +8
============================================
Files 1100 1100
Lines 141034 141080 +46
Branches 21846 21845 -1
============================================
+ Hits 16329 16333 +4
- Misses 123004 123047 +43
+ Partials 1701 1700 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you Past Illiani for adding these tests. They proved immediately useful when I accidentally deleted two skills and we'd have likely not noticed for months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the amount of new skills that have been recently added I'm really aware of how fragile our skill addition is. It's a lot of manual entry with a fair amount of stuff that can go wrong.
With a mind to making the process more secure I went ahead and added a handful of tests. These tests will run on every skill type and ensure full skill validity.