8000 Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Added Additional Science, Art & Interest Specializations by IllianiBird · Pull Request #6891 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Added Additional Science, Art & Interest Specializations #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Added Additional Science, Art & Interest Specializations #6891

merged 3 commits into from
May 7, 2025

Conversation

IllianiBird
Copy link
Collaborator
@IllianiBird IllianiBird commented May 6, 2025 •
edited
Loading

Barring the various weapon skills such as Melee Weapons and Throwing Weapons, this PR makes us compliant with all skills listed in A Time of War.

New Skills

  • Career/Any
  • Running
  • Swimming
  • Zero-G Operations
  • Melee Weapons
  • Support Weapons
  • Thrown Weapons

Art Specializations

  • Art/Poetry
  • Art/Cooking
  • Art/Instrument
  • Art/Sculpture
  • Art/Singing
  • Art/Other

Interest Specializations

  • Interest/Antiques
  • Interest/Archeology
  • Interest/Astrology
  • Interest/Cartography
  • Interest/Economics
  • Interest/Exotic Animals
  • Interest/Fashion
  • Interest/Fishing
  • Interest/Gambling
  • Interest/Holo-Cinema
  • Interest/Military
  • Interest/Music
  • Interest/Mythology
  • Interest/Philosophy
  • Interest/Politics
  • Interest/Pop-Culture
  • Interest/Theology
  • Interest/Other

Science Specializations

  • Science/Genetics
  • Science/Geology
  • Science/Military
  • Science/Pharmacology
  • Science/Psychology
  • Science/Xenobiology
  • Science/Other

@IllianiBird
Improvement: Added Additional Science, Art Specializations
968db2b 
### New Skills
- Career/Any
- Running
- Swimming
- Zero-G Operations

### Art
- Art/Poetry
- Art/Cooking
- Art/Instrument
- Art/Sculpture
- Art/Singing
- Art/Other

### Interest
- Interest/Antiques
- Interest/Archeology
- Interest/Astrology
- Interest/Cartography
- Interest/Economics
- Interest/Exotic Animals
- Interest/Fashion
- Interest/Fishing
- Interest/Gambling
- Interest/Holo-Cinema
- Interest/Military
- Interest/Music
- Interest/Mythology
- Interest/Philosophy
- Interest/Politics
- Interest/Pop-Culture
- Interest/Theology
- Interest/Other

### Science
- Science/Genetics
- Science/Geology
- Science/Military
- Science/Pharmacology
- Science/Psychology
- Science/Xenobiology
- Science/Other
@IllianiBird IllianiBird self-assigned this May 6, 2025
@IllianiBird IllianiBird added the Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule label May 6, 2025
@codecov Codecov
Copy link
codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.82456% with 46 lines in your changes missing coverage. Please review.

Project coverage is 11.67%. Comparing base (5237888) to head (7973dbc).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...src/mekhq/campaign/personnel/skills/SkillType.java 79.82% 46 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6891      +/-   ##
============================================
+ Coverage     11.58%   11.67%   +0.09%     
- Complexity     6620     6642      +22     
============================================
  Files          1100     1100              
  Lines        141071   141306     +235     
  Branches      21848    21845       -3     
============================================
+ Hits          16342    16497     +155     
- Misses       123029   123110      +81     
+ Partials       1700     1699       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Scoppio
Scoppio approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator
@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise me this will be turned into an enum next month

@IllianiBird
Copy link
Collaborator Author

I can promise that, because this is freaking awful.

@IllianiBird
Copy link
Collaborator Author

Added...

  • Melee Weapons
  • Support Weapons
  • Thrown Weapons

@IllianiBird IllianiBird changed the title Improvement: Added Career/Any, Running, Swimming, and Zero-G Operations skills; Additional Science, Art & Interest Specializations Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Additional Science, Art & Interest Specializations May 7, 2025
@IllianiBird IllianiBird changed the title Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Additional Science, Art & Interest Specializations Improvement: Added Career/Any, Running, Swimming, Melee Weapons, Thrown Weapons, Support Weapons and Zero-G Operations skills; Added Additional Science, Art & Interest Specializations May 7, 2025
@Scoppio Scoppio merged commit ce9d9c3 into MegaMek:master May 7, 2025
6 checks passed
@IllianiBird IllianiBird deleted the addedMissingSkills branch June 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scoppio Scoppio Scoppio approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @Scoppio
0