Feature: Added Tracking of Heroic and Legendary Skill Levels #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6904 +/- ##
============================================
+ Coverage 12.03% 12.09% +0.06%
- Complexity 6889 6958 +69
============================================
Files 1103 1105 +2
Lines 142332 142503 +171
Branches 22004 22064 +60
============================================
+ Hits 17133 17240 +107
- Misses 123364 123410 +46
- Partials 1835 1853 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces and enhances experience tracking beyond "Elite" by incorporating new skill levels – Heroic and Legendary – throughout the codebase. The key changes include:
- Updating logic comparisons from EXP_ELITE to EXP_LEGENDARY where parts or skills surpass Elite.
- Adding new constants and UI components for EXP_HEROIC and EXP_LEGENDARY in SkillType and related dialogs.
- Adjusting property files and personnel generator logic to account for the new experience thresholds.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/dialog/MRMSDialog.java | Modified filtering logic to use EXP_LEGENDARY for part eligibility. |
| MekHQ/src/mekhq/gui/campaignOptions/contents/AdvancementTab.java | Introduced new UI labels and spinners for Heroic and Legendary skill levels (with a potential duplication issue). |
| MekHQ/src/mekhq/campaign/personnel/skills/SkillType.java | Added EXP_HEROIC and EXP_LEGENDARY constants with updated mappings for level names and colors. |
| MekHQ/src/mekhq/campaign/Campaign.java, AtBDynamicScenarioFactory.java, Utilities.java, etc. | Updated various logic comparisons and thresholds to incorporate the new skill levels. |
| Resource property files | Updated labels/tooltips to reflect the new Heroic and Legendary settings. |
# Conflicts: # MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties # MekHQ/src/mekhq/campaign/personnel/skills/SkillType.java # MekHQ/src/mekhq/gui/campaignOptions/contents/AdvancementTab.java
| : adminHR.getSkill(SkillType.S_ADMIN).getExperienceLevel(); | ||
| int adminHRExp = (adminHR == null) ? | ||
| SkillType.EXP_ULTRA_GREEN : | ||
| adminHR.getSkill(SkillType.S_ADMIN).getExperienceLevel(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
# Conflicts: # MekHQ/src/mekhq/service/mrms/MRMSService.java
# Conflicts: # MekHQ/src/mekhq/campaign/parts/MissingPart.java # MekHQ/src/mekhq/campaign/parts/OmniPod.java # MekHQ/src/mekhq/campaign/parts/PodSpace.java # MekHQ/src/mekhq/service/mrms/MRMSService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was originally added to 50.06 but later removed due to the reduced scope of 50.06. Now it's back, ready for 50.07. For those unaware of the original PR, this just improves tracking of experience levels so that they can go above 'Elite'. The steps above that being 'Heroic' and 'Legendary'.