Improvement: Added Interest/Law; Fixed Incorrect Name of Constant #6917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
+ Complexity 6851 6850 -1
============================================
Files 1101 1101
Lines 141386 141377 -9
Branches 21897 21900 +3
============================================
- Hits 17028 17023 -5
+ Misses 122537 122531 -6
- Partials 1821 1823 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the new Interest/Law skill and fixes an incorrectly named constant.
- Added the Interest/Law skill including its constant definition, lookup entry, compatibility case, factory method, and corresponding properties entry.
- Renamed the outdated S_SCIENCE_SYSTEMS_MECHANICAL constant to S_SECURITY_SYSTEMS_MECHANICAL across lookup and factory references.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MekHQ/src/mekhq/campaign/personnel/skills/SkillType.java | Added Interest/Law skill and updated constant naming for security systems mechanical. |
| MekHQ/resources/mekhq/resources/SkillType.properties | Added flavor text for the new InterestLaw skill. |
HammerGS
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skill was missing from the earlier list and is needed for a future feature.