Improvement: Expanded Briefing Room Tutorial to Include Support Points & Reinforcing Scenarios; Fixed Formatting #6911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s & Reinforcing Scenarios; Fixed Formatting.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6911 +/- ##
============================================
- Coverage 11.97% 11.71% -0.26%
+ Complexity 6785 6673 -112
============================================
Files 1101 1101
Lines 141414 141413 -1
Branches 21901 21901
============================================
- Hits 16937 16571 -366
- Misses 122677 123141 +464
+ Partials 1800 1701 -99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR expands the tutorial content to include Support Points and Reinforcing Scenarios details while also addressing formatting issues in the MissionViewPanel.
- Adjusts UI layout in MissionViewPanel.java by modifying gridBagConstraints and removing an unnecessary horizontal spacer.
- Extends the tutorial text in ContractViewPanel.properties to provide additional guidance on support mechanics in StratCon.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/view/MissionViewPanel.java | Adjusts UI layout settings and updates header comments for correct attribution. |
| MekHQ/resources/mekhq/resources/ContractViewPanel.properties | Adds expanded tutorial content for Support Points and Reinforcing Scenarios. |
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/gui/view/MissionViewPanel.java:173
- Verify that increasing the weightx value from 1.0 to 2.0 aligns with the intended UI layout behavior across different window sizes.
gridBagConstraints.weightx = 2.0;
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign
6FEE
up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting was fine when tested, but became wonky once merged most likely due to some merge condition. Either way, it's fixed now.