Improvement: Changed Dependent Joining or Leaving Messaging to use Civilian Terminology and State Profession #6927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vilian Terminology and State Profession
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6927 +/- ##
============================================
- Coverage 12.04% 12.03% -0.01%
+ Complexity 6851 6848 -3
============================================
Files 1101 1101
Lines 141386 141372 -14
Branches 21897 21900 +3
============================================
- Hits 17028 17020 -8
+ Misses 122537 122530 -7
- Partials 1821 1822 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates personnel messaging to use civilian terminology and state profession instead of the generic "Dependent" label.
- Refactored the joining message in RandomDependents.java to include the personnel’s primary role label.
- Modified resource bundle messages in RandomDependents.properties to reflect civilian terminology for both joining and leaving events.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MekHQ/src/mekhq/campaign/personnel/RandomDependents.java | Updated the report generation to include a profession label and reordered import statements. |
| MekHQ/resources/mekhq/resources/RandomDependents.properties | Adjusted message templates to replace "Dependent" with "Civilian" terminology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, rather than stating 'x has joined as a Dependent' the civilian joining message will state 'x has joined as a '. Right now that's just going to show 'Dependent', but when #6920 goes live this will be much more impactful.