Improvement: Improved Display of Civilian Professions #6923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6923 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
+ Complexity 6851 6850 -1
============================================
Files 1101 1101
Lines 141386 141394 +8
Branches 21897 21907 +10
============================================
- Hits 17028 17025 -3
- Misses 122537 122545 +8
- Partials 1821 1824 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves how civilian professions are displayed in the UI by styling them in italics and clearly distinguishing between Children, Students, and normal Dependents. Key changes include:
- Updating PersonnelTableModelColumn to call a new formatting method for role descriptions.
- Adding a new method in Person.java to generate HTML-formatted role descriptions with appropriate styling.
- Replacing multiple explicit enum imports with a wildcard import in Person.java.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java | Updated the role description method call to use the new formatting method. |
| MekHQ/src/mekhq/campaign/personnel/Person.java | Added the new HTML-formatted role description method and updated enum imports. |
Comments suppressed due to low confidence (2)
MekHQ/src/mekhq/campaign/personnel/Person.java:1012
- [nitpick] The method name 'getFormatedRoleDescriptions' appears to be misspelled; consider renaming it to 'getFormattedRoleDescriptions' for improved clarity.
public String getFormatedRoleDescriptions(LocalDate today) {
MekHQ/src/mekhq/campaign/personnel/Person.java:97
- [nitpick] Using a wildcard import may decrease code clarity and could inadvertently import unwanted classes; consider using explicit imports to better manage dependencies in accordance with project style guidelines.
import mekhq.campaign.personnel.enums.*;
HammerGS
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Civilian professions will now display in italics and we properly differentiate between Children, Students, and normal Dependents. The goal here is to make civilian roles visually stand out from normal roles, so players cannot mistake which is which.
This is designed to work with #6920, but there's no reason for it to wait until that PR merges.