Improvement: Improved Display of Long Named Professions in Personnel Tab by Moving Salary to Biographies Filter #6932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tab by Moving Salary to Biographys Filter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6932 +/- ##
=========================================
Coverage 12.04% 12.04%
- Complexity 6851 6853 +2
=========================================
Files 1101 1101
Lines 141386 141372 -14
Branches 21897 21900 +3
=========================================
+ Hits 17028 17029 +1
+ Misses 122537 122519 -18
- Partials 1821 1824 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the display of long profession names in the personnel tab by adjusting column widths and moving the SALARY filtering logic to the Biographies filter.
- Updated the column width for PERSONNEL_ROLE from 100 to 150.
- Refactored the switch logic in PersonnelTableModelColumn to move the SALARY case from one branch to a different (Biographies) branch.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MekHQ/unittests/mekhq/gui/enums/PersonnelTableModelColumnTest.java | Added unit tests asserting the updated width for the PERSONNEL_ROLE column. |
| MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java | Adjusted column widths and refactored the filter logic, moving the SALARY check to the Biographies filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When professions with long names were entered into the personnel table they would become oddly squashed. This mitigates that problem.