Improvement: Added Tooltips to Professions Showing Associated Skills and Their Linked Attributes #6946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default experience level for professions without skills. Added missing skills to vehicle crew eligibility
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6946 +/- ##
============================================
+ Coverage 11.97% 12.04% +0.06%
- Complexity 6789 6851 +62
============================================
Files 1101 1101
Lines 141489 141386 -103
Branches 21915 21897 -18
============================================
+ Hits 16950 17028 +78
+ Misses 122741 122537 -204
- Partials 1798 1821 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves tooltip functionality for professions by adding detailed descriptions of associated skills and attributes, as well as updating corresponding tests and refactoring skill assignment logic. Key changes include updating tooltip generation in the PersonnelRole enum, modifying overrideSkills method signatures to include an artillery flag, and enhancing test coverage using parameterized tests.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MekHQ/unittests/mekhq/campaign/personnel/enums/PersonnelRoleTest.java | Updated test methods to use parameterized tests and removed obsolete combat/civilian tests. |
| MekHQ/src/mekhq/gui/dialog/HireBulkPersonnelDialog.java | Added an extra boolean parameter for artillery usage in the overrideSkills call. |
| MekHQ/src/mekhq/gui/adapter/UnitTableMouseAdapter.java | Updated the overrideSkills invocation to include the new artillery flag. |
| MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java | Added tooltips to role menu items using a word wrapping utility. |
| MekHQ/src/mekhq/gui/CampaignGUI.java | Integrated the new tooltip functionality in the hire menu items. |
| MekHQ/src/mekhq/campaign/randomEvents/RoninOffer.java | Updated overrideSkills call to include the artillery flag. |
| MekHQ/src/mekhq/campaign/personnel/skills/SkillType.java | Changed the representation for a -1 experience level and added a helper to retrieve attributes. |
| MekHQ/src/mekhq/campaign/personnel/generator/AbstractSkillGenerator.java | Refactored default skills generation to iterate over profession skills instead of using a switch-case. |
| MekHQ/src/mekhq/campaign/personnel/enums/PersonnelRole.java | Added getDescription, getTooltip, and overloaded getSkillsForProfession methods to support enhanced tooltips. |
| MekHQ/src/mekhq/campaign/personnel/PersonUtility.java | Reworked overrideSkills to delegate to the new signature and updated deprecation documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6918