Fix: Stopped Characters Resigning While Campaign is In Transit (Again) #6947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6947 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
+ Complexity 6851 6849 -2
============================================
Files 1101 1101
Lines 141386 141371 -15
Branches 21897 21900 +3
============================================
- Hits 17028 17023 -5
+ Misses 122537 122525 -12
- Partials 1821 1823 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR changes the logic to prevent character resignations when the campaign location is not on a planet.
- Changed condition in Campaign.java from checking if the location is in transit to checking if it is not on a planet.
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/campaign/Campaign.java:9176
- Changing the condition from 'location.isInTransit()' to '!location.isOnPlanet()' alters the intended check for when characters should resign. Please confirm that this new condition accurately covers all relevant off-planet scenarios and does not inadvertently block valid resignations in situations that are not strictly 'in transit'.
if (!location.isOnPlanet()) {
HammerGS
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seriously, where would they go?