Fix: #6937 Fixed Display of Implants in New Person View Panel #6940
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6940 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
+ Complexity 6851 6847 -4
============================================
Files 1101 1101
Lines 141386 141376 -10
Branches 21897 21900 +3
============================================
- Hits 17028 17023 -5
+ Misses 122537 122529 -8
- Partials 1821 1824 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the display issue for implants in the New Person View Panel by correctly treating implants as distinct from special abilities. Key changes include:
- Changing the getRelevantAbilities() method to return a Map<IOption, String> instead of a List.
- Refactoring the fillAbilitiesAndImplants() method to iterate over the map of abilities and implants.
- Updating documentation to reflect the new behavior and method contracts.
| int counter = 0; | ||
| for (IOption option : relevantAbilities.keySet()) { | ||
| int column = counter / skillsPerColumn; // 0, 1 | ||
| int row = counter % skillsPerColumn; | ||
|
|
||
| SpecialAbility ability = relevantAbilities.get(i); | ||
| String name = ability.getDisplayName(); | ||
| String description = ability.getDescription(); | ||
| boolean isFlaw = ability.getCost() < -1; // -1 is used to designate an origin only SPA | ||
| < 8000 td data-line-number="1900" class="blob-num blob-num-addition"> | String name = option.getDisplayableName(); | |
| String description = option.getDescription(); | ||
|
|
||
| boolean isFlaw = false; | ||
| if (Objects.equals(relevantAbilities.get(option), LVL3_ADVANTAGES)) { |
There was a problem hiding this comment.
[nitpick] Consider refactoring the iteration over relevantAbilities by using a for-each loop over the Map.Entry<IOption, String> instead of manually managing the counter. This would improve code readability and maintainability.
Copilot uses AI. Check for mistakes.
Fix #6937
It turns out implants are not special abilities but they are treated as SPAs. It's a whole thing, but now we correctly account for them in the updated person view.