8000 Fix: Restored Access to Units Involved in Prior Scenarios by IllianiBird · Pull Request #6942 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Restored Access to Units Involved in Prior Scenarios #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IllianiBird
Copy link
Collaborator

The restoration of the ability to see what units were involved in prior scenarios was requested by QA. This PR restores it. However, while I have been unable to run into any exceptions through testing I recall #6796 was actually pretty hard to replicate so I'm going to mark this for 50.07 so we have time to run into any issues during a full development cycle.

@IllianiBird IllianiBird self-assigned this May 9, 2025
Copy link
codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (49d3af0) to head (329ddd5).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/view/AtBScenarioViewPanel.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6942   +/-   ##
=========================================
  Coverage     12.03%   12.03%           
  Complexity     6889     6889           
=========================================
  Files          1103     1103           
  Lines        142284   142284           
  Branches      21991    21991           
=========================================
+ Hits          17121    17125    +4     
+ Misses       123328   123324    -4     
  Partials       1835     1835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird marked this pull request as ready for review May 19, 2025 23:10
@IllianiBird IllianiBird requested a review from a team as a code owner May 19, 2025 23:10
@IllianiBird IllianiBird merged commit 4a3b26a into MegaMek:master May 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0