Improvement: Added a Hint Display to Campaign Options IIC #6958
Conversation
There was a problem hiding this comment.
Overall looks good, but the CI/CD task is failing with these errors:
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/gui/campaignOptions/contents/PersonnelTab.java:1420: error: method getDescription in enum PersonnelRole cannot be applied to given types;
jLabel.addMouseListener(createTipPanelUpdater(salariesHeader, null, personnelRole.getDescription(false)));
^
required: no arguments
found: boolean
reason: actual and formal argument lists differ in length
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/gui/campaignOptions/contents/PersonnelTab.java:1428: error: method getDescription in enum PersonnelRole cannot be applied to given types;
jSpinner.addMouseListener(createTipPanelUpdater(salariesHeader, null, personnelRole.getDescription(false)));
^
required: no arguments
found: boolean
reason: actual and formal argument lists differ in length
/home/runner/work/mekhq/mekhq/mekhq/MekHQ/src/mekhq/gui/campaignOptions/contents/BiographyTab.java:1405: error: method getDescription in enum PersonnelRole cannot be applied to given types;
role.getDescription(false)));
^
required: no arguments
found: boolean
reason: actual and formal argument lists differ in length
Probably need to either rebase on a newer master, or update those calls.
|
Yeah that method comes from the PR marked as required for this PR |
I thought I looked... nope, there it is. |
|
@IllianiBird I merged the prerequisite PR but it looks like either A) GitHub isn't seeing it yet, or B) we still need to do a merge/rebase to pull those updates into this PR so the CI can pass. At this point I can try to do that, or you can, or we can merge and then you can fix anything that is subsequently broken. |
|
Should be good now (once the tests complete) I just had to remerge master so it recognized that the source method did, in fact, exist. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6958 +/- ##
============================================
- Coverage 12.03% 11.99% -0.05%
- Complexity 6851 6858 +7
============================================
Files 1101 1101
Lines 141441 142012 +571
Branches 21920 21934 +14
============================================
+ Hits 17029 17036 +7
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Requires #6960
We were noticing that even with all of the informatics added to CO IIC folks were still missing the tooltips. So traditional problems require modern solutions.
A 'hint' panel has been added to CO IIC's tabs, where appropriate. When a user mouses over an option this hint panel will be updated to display the tooltips linked in that option. So, for example, if I were to mouse over 'enable StratCon' the hint panel will update to show the 'enable StratCon' tooltips.
For user convenance the tooltips are still in place, so if a user prefers they can access the information in the old manner without issue.
They say a picture paints a thousand words, so...
Screen.Recording.2025-05-11.at.3.43.13.PM.mov