8000 Fix for Capital Ship Armor Repair Time by savanik · Pull Request #6964 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix for Capital Ship Armor Repair Time #6964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Fix for Capital Ship Armor Repair Time #6964

merged 2 commits into from
May 14, 2025

Conversation

savanik
Copy link
Contributor
@savanik savanik commented May 12, 2025

Fixes issue #175. Updates armor part with correct times for capital scale ships per Master Repair Table in StratOps p183.

@savanik
Resolves issue MegaMek#175. Updates armor part with correct times for…
8000
6c22ee2 
… capital scale ships per Master Repair Table in StratOps p183.
@savanik savanik requested a review from a team as a code owner May 12, 2025 21:58
@savanik
Resolves issue MegaMek#175. Updates armor part with correct times for…
c1565de 
… capital scale ships per Master Repair Table in CamOps p207.
@savanik
Copy link
Contributor Author
savanik commented May 13, 2025

@Scoppio This is the capital armor fix I was talking about tonight!

@codecov Codecov
Copy link
codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (c24b3e0) to head (c1565de).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/parts/Armor.java 23.52% 7 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6964   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6852     6856    +4     
=========================================
  Files          1101     1101           
  Lines        141438   141444    +6     
  Branches      21917    21916    -1     
=========================================
+ Hits          17026    17040   +14     
+ Misses       122597   122582   -15     
- Partials       1815     1822    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 5ce3d14 into MegaMek:master May 14, 2025
6 checks passed
@savanik savanik deleted the fixCapitalArmorRepairTimes branch May 20, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savanik @Sleet01
0