8000 Improvement: Changed Default Acquisitions Skill from Negotiation to Administration in Stock Presets and New Player Quickstart Campaign by IllianiBird · Pull Request #6966 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvement: Changed Default Acquisitions Skill from Negotiation to Administration in Stock Presets and New Player Quickstart Campaign #6966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

IllianiBird
Copy link
Collaborator

All admin professions require 2 skills: negotiation and administration. However Admin/Logi were only using negotiation. This switches those personnel to use administration for procurement, and then negotiation for Resupply interactions offering a more balanced experience.

…dministration in Stock Presets and New Player Quickstart Campaign
@IllianiBird IllianiBird self-assigned this May 12, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 12, 2025 23:43
@IllianiBird IllianiBird added Personnel Personnel-related Issues UX User experience Campaign Options Relates to, or includes, campaign option changes labels May 12, 2025
Copy link
codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.04%. Comparing base (c24b3e0) to head (d485c98).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6966   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6852     6854    +2     
=========================================
  Files          1101     1101           
  Lines        141438   141438           
  Branches      21917    21917           
=========================================
+ Hits          17026    17030    +4     
+ Misses       122597   122585   -12     
- Partials       1815     1823    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird merged commit 2f1cde9 into MegaMek:master May 13, 2025
6 checks passed
@IllianiBird IllianiBird deleted the negotiationToAdministration branch June 7, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign Options Relates to, or includes, campaign option changes Personnel Personnel-related Issues UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0