8000 Improvement: Added Scenario Briefing Dialog to Briefing Room on Scenario Start by IllianiBird · Pull Request #6969 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvement: Added Scenario Briefing Dialog to Briefing Room on Scenario Start #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator
@IllianiBird IllianiBird commented May 13, 2025

When the player selects 'Start Game' in the Briefing Room instead of going straight to the connection dialog they are presented with the scenario briefing.

The briefing will be delivered by a representative of the contact employer. This representative will deliver all briefings for the duration of the contract, becoming a familiar name the player can latch onto.

The briefing will be delivered to the most senior member of the drop.

This feature is for Legacy AtB and StratCon enabled campaigns only due to a reliance on code that is exclusive to the Digital GMs.

The persistent employer representative feature is available for Legacy AtB and StratCon enabled campaigns only.

image

@IllianiBird IllianiBird self-assigned this May 13, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 13, 2025 03:40
@IllianiBird IllianiBird added AtB GUI StratCon Bugs relating strictly to StratCon UX User experience labels May 13, 2025
Copy link
codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 0.61728% with 161 lines in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (c24b3e0) to head (f7b2676).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/mission/AtBContract.java 1.08% 91 Missing ⚠️
MekHQ/src/mekhq/gui/BriefingTab.java 0.00% 41 Missing ⚠️
MekHQ/src/mekhq/campaign/mission/Mission.java 0.00% 10 Missing ⚠️
...mponents/immersiveDialogs/ImmersiveDialogCore.java 0.00% 10 Missing ⚠️
...kHQ/src/mekhq/gui/dialog/ContractMarketDialog.java 0.00% 3 Missing ⚠️
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 2 Missing ⚠️
.../market/contractMarket/AbstractContractMarket.java 0.00% 2 Missing ⚠️
MekHQ/src/mekhq/campaign/mission/Contract.java 0.00% 1 Missing ⚠️
...ampaign/storyarc/storypoint/MissionStoryPoint.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6969      +/-   ##
============================================
- Coverage     12.03%   12.03%   -0.01%     
- Complexity     6852     6855       +3     
============================================
  Files          1101     1101              
  Lines        141438   141499      +61     
  Branches      21917    21933      +16     
============================================
+ Hits          17026    17031       +5     
- Misses       122597   122644      +47     
- Partials       1815     1824       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird
Copy link
Collaborator Author
  • Updated to include code that means this isn't restricted to AtB and StratCon only

Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sleet01 Sleet01 merged commit 9cb58ea into MegaMek:master May 14, 2025
6 checks passed
Copy link
tapenvy-sentry bot commented May 15, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NullPointerException: Cannot invoke "String.isBlank()" because "this.bloodname" is null mekhq.campaign.personnel.Person in getAdjustedR... View Issue
  • ‼️ ExecutionException: java.lang.OutOfMemoryError: Java heap space mekhq.gui.dialog.DataLoadingDialog$Task in done View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB GUI StratCon Bugs relating strictly to StratCon UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0