8000 Fix: Added Missing Commander Address from Convoy Roleplay Events by IllianiBird · Pull Request #6974 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Added Missing Commander Address from Convoy Roleplay Events #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Fix: Added Missing Commander Address from Convoy Roleplay Events #6974

merged 2 commits into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator

We were missing the commander's address from convoy roleplay events. Now we're not.

@IllianiBird IllianiBird self-assigned this May 13, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 13, 2025 17:51
@IllianiBird IllianiBird added Bug GUI Severity: Medium Issues described as medium severity as per the new issue form labels May 13, 2025
@codecov Codecov
Copy link
codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (c24b3e0) to head (3dd8ad7).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
...ign/mission/resupplyAndCaches/PerformResupply.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6974   +/-   ##
=========================================
  Coverage     12.03%   12.03%           
- Complexity     6852     6853    +1     
=========================================
  Files          1101     1101           
  Lines        141438   141438           
  Branches      21917    21917           
=========================================
+ Hits          17026    17029    +3     
+ Misses       122597   122592    -5     
- Partials       1815     1817    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 0335be7 into MegaMek:master May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug GUI Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @Sleet01
0