8000 Fix: #6952 Fixed Copy-Paste Errors in Skill Tooltips; Fixed Closing Braces in Skill Tooltips; Stopped Empty Skill SubType Menus Appearing in Personnel Right-Click Menu by IllianiBird · Pull Request #6988 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #6952 Fixed Copy-Paste Errors in Skill Tooltips; Fixed Closing Braces in Skill Tooltips; Stopped Empty Skill SubType Menus Appearing in Personnel Right-Click Menu #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Fix: #6952 Fixed Copy-Paste Errors in Skill Tooltips; Fixed Closing Braces in Skill Tooltips; Stopped Empty Skill SubType Menus Appearing in Personnel Right-Click Menu #6988

merged 1 commit into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator

Fix #6952

@IllianiBird IllianiBird self-assigned this May 13, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 13, 2025 23:36
@IllianiBird IllianiBird added Bug GUI Severity: Low Issues described as low severity as per the new issue form labels May 13, 2025
@codecov Codecov
Copy link
codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (c24b3e0) to head (ee69ea5).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% 40 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6988   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6852     6856    +4     
=========================================
  Files          1101     1101           
  Lines        141438   141459   +21     
  Branches      21917    21937   +20     
=========================================
+ Hits          17026    17039   +13     
- Misses       122597   122600    +3     
- Partials       1815     1820    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 50f15b9 into MegaMek:master May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug GUI Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Tooltip typos under "Spend XP" Menu (Nightly 1854)
2 participants
@IllianiBird @Sleet01
0