8000 Fix: #6948 Fixed Artillery Skill Only Being Factored into a Character's Experience Level when Use Artillery Skill is Disabled by IllianiBird · Pull Request #6989 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #6948 Fixed Artillery Skill Only Being Factored into a Character's Experience Level when Use Artillery Skill is Disabled #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Fix: #6948 Fixed Artillery Skill Only Being Factored into a Character's Experience Level when Use Artillery Skill is Disabled #6989

merged 1 commit into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator

Fix #6948

This was caused by an inverted conditional, one of the classic blunders.

@IllianiBird
Fix: Fixed Artillery Skill Only Being Factored into a Character's Exp…
53ea69e 
…erience Level when Use Artillery Skill is Disabled
@IllianiBird IllianiBird self-assigned this May 13, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 13, 2025 23:49
@IllianiBird IllianiBird added Bug Personnel Personnel-related Issues Severity: High Issues described as high severity as per the new issue form labels May 13, 2025
@IllianiBird IllianiBird changed the title Fix: Fixed Artillery Skill Only Being Factored into a Character's Experience Level when Use Artillery Skill is Disabled Fix: #6948 Fixed Artillery Skill Only Being Factored into a Character's Experience Level when Use Artillery Skill is Disabled May 13, 2025
psikomonkie
psikomonkie approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator
@psikomonkie psikomonkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it really just this? It wasn’t what was working on & was worried there’d be more to it. You rock Illiani!

@codecov Codecov
Copy link
codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (c24b3e0) to head (53ea69e).
Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/personnel/Person.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6989   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6852     6854    +2     
=========================================
  Files          1101     1101           
  Lines        141438   141438           
  Branches      21917    21917           
=========================================
+ Hits          17026    17031    +5     
+ Misses       122597   122582   -15     
- Partials       1815     1825   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird
Copy link
Collaborator Author

Yeah, I double-checked with a fresh campaign and was able to confirm this was literally it. I really need to be more careful with conditionals, because this keeps happening.

@Sleet01 Sleet01 merged commit c506714 into MegaMek:master May 14, 2025
6 checks passed
@IllianiBird IllianiBird deleted the artilleryExperienceLevelFix branch June 7, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psikomonkie psikomonkie psikomonkie approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug Personnel Personnel-related Issues Severity: High Issues described as high severity as per the new issue form
Projects
None yet
Milestone
No 4497 milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Incorrect Skill Level
3 participants
@IllianiBird @psikomonkie @Sleet01
0