Fix: #6788, #6979 Fixed Naming of MekTech Portrait Folders & Portraits #6981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6981 +/- ##
============================================
- Coverage 12.03% 12.03% -0.01%
+ Complexity 6852 6849 -3
============================================
Files 1101 1101
Lines 141438 141438
Branches 21917 21917
============================================
- Hits 17026 17025 -1
+ Misses 122597 122592 -5
- Partials 1815 1821 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can this / does this need to include some kind of “migration” for personnel using the old path? Or are the name/numbers totally different between MekTek/MekTech? |
|
Lemme see what I can do. If we're lucky the migration code I put in during The Great Renaming should still be present and functioning. |
|
Done, it's part of MegaMek so incorporated into MegaMek/megamek#7045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6788
Fix #6979
The 'Mek Tech' folder should have been 'MekTech'. A separate PR will handle this fix in MegaMek.
I also corrected the file naming from 'MekTek' to 'MekTech' to match MegaMek. This resolves the issue of duplicate portraits.