Fix: #6998 Fixed Tactics Bonus to No Longer Use the Tactic Number as a Bonus #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6999 +/- ##
=========================================
Coverage 12.03% 12.04%
- Complexity 6852 6854 +2
=========================================
Files 1101 1101
Lines 141438 141438
Branches 21917 21919 +2
=========================================
+ Hits 17026 17033 +7
+ Misses 122597 122579 -18
- Partials 1815 1826 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6998
Related Issue MegaMek/megamek#7054
The initiative bonus from Tactics, when that campaign option was enabled, was incorrectly using the skill target number as a modifier and not the combined skill levels, bonus, and aging modifiers.
I also fixed a bug where Tactics was not being applied to the unit if Individual Initiative Tactics Modifiers was enabled.
Finally I fixed a third bug where Commander Initiative wasn't being enabled in MegaMek when the above mentioned option was enabled.
There is a forth related bug, but that's a wholly MegaMek issue and is being handled by Sleet. But basically if individual initiative was enabled we are still using the highest initiative from all units under a player's control not just the modifiers from the specific unit making the roll.