8000 Improvement: #6878 Added the Ability to Hide Personalities on Individual Characters by IllianiBird · Pull Request #6991 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvement: #6878 Added the Ability to Hide Personalities on Individual Characters #6991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator

Fix #6878

The player just needs to select the character (or characters) they want to hide the personality of, hit 'hide personality' and that characters personality will be hidden. This allows the player to write their own descriptions, using the biography panel in Edit Person, without needing to disable the entire random personality system.

@IllianiBird IllianiBird self-assigned this May 14, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 14, 2025 00:21
@IllianiBird IllianiBird added Personnel Personnel-related Issues UX User experience labels May 14, 2025
Copy link
codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (c24b3e0) to head (1a99f96).
Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% 13 Missing ⚠️
MekHQ/src/mekhq/campaign/personnel/Person.java 0.00% 6 Missing ⚠️
MekHQ/src/mekhq/gui/view/PersonViewPanel.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6991   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6852     6853    +1     
=========================================
  Files          1101     1101           
  Lines        141438   141459   +21     
  Branches      21917    21921    +4     
=========================================
+ Hits          17026    17032    +6     
- Misses       122597   122602    +5     
- Partials       1815     1825   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 982174c into MegaMek:master May 14, 2025
6 checks passed
@IllianiBird IllianiBird deleted the hidePersonalities branch June 7, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Ability to hide personality descriptions on a per-character basis
2 participants
0