Fixes for issue #7004 - Purchase Unit Dialog Button Behavior #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore consistent behavior.
IllianiBird
approved these changes
May 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #7004 by ensuring that the Purchase and Add(GM) buttons in the Purchase Unit dialog are disabled until a unit is selected, resulting in a more consistent user experience.
- Sets buttons to be disabled by default until a valid selection is made.
- Refactors several code sections for improved clarity and consistency.
- Reformats the complex filtering condition to improve readability.
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/gui/dialog/MekHQUnitSelectorDialog.java:278
- [nitpick] The complex filtering logic in the include method, while functionally correct, could benefit from extraction into a dedicated helper method. This refactor would improve readability and simplify future maintenance.
/* Clan/IS limits */ && (campaign.getCampaignOptions().isAllowClanPurchases() || !TechConstants.isClan(mek.getType())) && (campaign.getCampaignOptions().isAllowISPurchases() || TechConstants.isClan(mek.getType())) ...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7005 +/- ##
============================================
- Coverage 12.03% 11.99% -0.05%
- Complexity 6852 6862 +10
============================================
Files 1101 1102 +1
Lines 141438 142148 +710
Branches 21917 21980 +63
============================================
+ Hits 17026 17047 +21
- Misses 122597 123277 +680
- Partials 1815 1824 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7004. Gives buttons in the Purchase Unit dialog more consistent behavior by disabling the Purchase and Add(GM) button until a unit is selected. (Also lots of reformatting, apparently)