Fix: #7007 Fixed Cancel Deployment Producing Scenario with 0 BV Budget #7009
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7009 +/- ##
=========================================
Coverage 11.98% 11.98%
+ Complexity 6860 6856 -4
=========================================
Files 1102 1102
Lines 142197 142150 -47
Branches 21989 21977 -12
=========================================
- Hits 17039 17038 -1
+ Misses 123333 123288 -45
+ Partials 1825 1824 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does the system support a two-step process:
IIRC this is how the MegaMek unit configuration dialog works: the player's changes are recorded in the dialog state itself, but only applied to the unit(s) if the player clicks "OK". |
|
The Scenario is added to the Mission the moment it's spawned. The issue was around the BV Budget allocated to forces within that scenario. What we would need to do, to solve the 'backing out of an ambush' problem is have this dialog predate the spawning of the scenario but with sufficient knowledge to know that a scenario will be spawned. The problem is that, insofar as I can see, StratCon was never built with this interaction in mind. |
Fix #7007
When a player deploys to a hidden scenario we generate the scenario, including the BV budget of forces assigned to that scenario. However, if the player cancels deployment - at that moment - the budget was getting set to 0 because we were not correctly resetting the scenario. This was due to the conditional that checked for the deployment being canceled was not functioning fully. However, as the force didn't get deployed it gave the impression that it was fully functional.
We fixed this by added a new variable to the deployment wizard that explicitly states whether the deployment was canceled. If that event comes to pass the scenario is reset fully. However, the originally generated force is not, preventing the 0 BV bug.
Design Notes
The cancel deployment bug is a hacky solution to a UX problem and one we should really rethink. However, such a task isn't on my schedule so would need to be picked up by another developer. Basically the problem we have to solve is that players sometimes want to backtrack out of deployment. However, if the player force is 'ambushed' (i.e. the scenario is populated at point of deployment) the player should - at that point - be barred from canceling the deployment as their force has been ambushed.